fix: treat images with initial slash as local, and resolve with vite #12030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0eed33 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Sep 19, 2024
Princesseuh
approved these changes
Sep 19, 2024
Merged
1 task
Closed
1 task
jcayzac
reviewed
Sep 26, 2024
| @@ -16,7 +16,7 @@ export function imageSrcToImportId(imageSrc: string, filePath?: string): string | |||
| imageSrc = removeBase(imageSrc, IMAGE_IMPORT_PREFIX); | |||
|
|
|||
| // We only care about local imports | |||
| if (isRemotePath(imageSrc) || imageSrc.startsWith('/')) { | |||
| if (isRemotePath(imageSrc)) { | |||
There was a problem hiding this comment.
note: isRemote() incorrectly assumes remote URLs all start with a protocol, so the code now won't catch //foo.com/bar.jpg anymore, which it still should?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously we treated images that start with a slash as public images, and didn;t process them. Turns out that this is changed behaviour, so we'll switch to resolving them via Vite.
Fixes #12025
Testing
Added several test cases
Docs